src/winsup/cygwin ChangeLog grp.cc

[Eric Blake]

CVSROOT: /cvs/src
Module name: src
winsup/cygwin : ChangeLog grp.cc
* grp.cc (get_groups): Don't add gid to list if it's ILLEGAL_GID.
(getgrouplist): Return number of groups, just like glibc.
http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/ChangeLog.diff?cvsroot=src&r1=1.6341&r2=1.6342
http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/grp.cc.diff?cvsroot=src&r1=1.125&r2=1.126

This patch is wrong.

@@ -626,7 +626,7 @@
}
if (cnt > *ngroups)
ret = -1;
- *ngroups = cnt;
+ ret = *ngroups = cnt;

getgrouplist has the documented behavior of setting *ngroups to the
number of groups that would be returned, even if the user passed a
too-small *ngroups in to begin with - in that case, ret MUST be -1, but
you just blindly set it to a too-large value. That is, ret must be <=
the initial value of *ngroups, and on output *ngroups must always be
positive even when ret is negative.

[Corinna Vinschen]

Post by Eric Blake

* grp.cc (get_groups): Don't add gid to list if it's ILLEGAL_GID.
(getgrouplist): Return number of groups, just like glibc.
http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/ChangeLog.diff?cvsroot=src&r1=1.6341&r2=1.6342
http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/grp.cc.diff?cvsroot=src&r1=1.125&r2=1.126

This patch is wrong.

@@ -626,7 +626,7 @@
}
if (cnt > *ngroups)
ret = -1;
- *ngroups = cnt;
+ ret = *ngroups = cnt;

getgrouplist has the documented behavior of setting *ngroups to the
number of groups that would be returned, even if the user passed a
too-small *ngroups in to begin with - in that case, ret MUST be -1, but
you just blindly set it to a too-large value. That is, ret must be <=
the initial value of *ngroups, and on output *ngroups must always be
positive even when ret is negative.

Thanks for the heads up. Fixed in CVS.


Corinna


P.S.: Eric, is there any chance we can get newer bash and coreutils
any time soon? Pretty please?